Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README update and some cleanups. #120

Merged
merged 2 commits into from
Sep 5, 2024
Merged

README update and some cleanups. #120

merged 2 commits into from
Sep 5, 2024

Conversation

fujitatomoya
Copy link
Collaborator

No description provided.

fujitatomoya
fujitatomoya commented Aug 27, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette @wjwwood minor update mostly docs, can you take a look?

rcl_logging_spdlog/README.md Show resolved Hide resolved
clalancette
clalancette requested changes Aug 27, 2024
View reviewed changes
rcl_logging_noop/CMakeLists.txt Outdated Show resolved Hide resolved
@fujitatomoya
Copy link
Collaborator Author

@clalancette requesting another review on this.

@fujitatomoya
Copy link
Collaborator Author

Pulls: #120
Gist: https://gist.githubusercontent.com/fujitatomoya/38f6efeffacfd7206e46612c78a45217/raw/276f1d6e84baef70790959dc1b765419f16697f0/ros2.repos
BUILD args: --packages-up-to rcl_logging_noop rcl_logging_spdlog
TEST args: --packages-select rcl_logging_noop rcl_logging_spdlog
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14512

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@ahcorde ahcorde merged commit 4d186fa into rolling Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde ahcorde approved these changes

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @clalancette @ahcorde