rcl_yaml_param_parser: Rearrange test logic to avoid refererence to null

[brawner]

This is another theoretical issue flagged by scan-build. I don't think it's actually practically possible given the null checks above it. I suspect the issue is that EXPECT_TRUE captures its arguments by reference.

/home/brawner/workspace/ros2_master/src/ros2/rcl/rcl_yaml_param_parser/test/test_parse_yaml.cpp:83:5: warning: Forming reference to null pointer
    EXPECT_TRUE(*param_value->bool_value);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/brawner/workspace/ros2_master/install/gtest_vendor/src/gtest_vendor/include/gtest/gtest.h:1969:3: note: expanded from macro 'EXPECT_TRUE'
  GTEST_TEST_BOOLEAN_(condition, #condition, false, true, \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/brawner/workspace/ros2_master/install/gtest_vendor/src/gtest_vendor/include/gtest/internal/gtest-internal.h:1325:7: note: expanded from macro 'GTEST_TEST_BOOLEAN_'
      ::testing::AssertionResult(expression)) \
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Stephen Brawner [email protected]

[brawner]

Testing --packages-select rcl_yaml_param_parser

• Linux
• Linux-aarch64
• macOS
• Windows

[brawner]

Windows cmake warnings are due to a planned deprecation and are unrelated to this PR.