You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like there are new functions in action_server.c, but I don't see new declarations for them in action_server.h. Forget to commit that file?
@sloretz These functions are declared in rcl_action/wait.h. Maybe it would be more clear if we either move wait set related declarations into action_client.h and action_server.h or create a new wait.c with their implementations?
Maybe it would be more clear if we either move wait set related declarations into action_client.h and action_server.h or create a new wait.c with their implementations?
Either of those would help, but I should have looked a little harder.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jacobperron
added
in progress
Closes #306
Up to rcl_action: