Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes integration tests for action client/server #331

Merged
merged 5 commits into from
Nov 29, 2018
Merged

Completes integration tests for action client/server #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bde76ab
[rcl action] Augments test_action_communication test.
hidmic Nov 13, 2018
4ee3182
Updated action tests to match the updated API
apojomovsky Nov 22, 2018
d03d560
Addressed peer review comments
apojomovsky Nov 27, 2018
10eebe3
Added checks for wait set entities
apojomovsky Nov 27, 2018
aead129
Addressed peer review comments v2
apojomovsky Nov 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rcl_action/src/rcl_action/action_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ rcl_action_client_get_default_options(void)
#define SEND_SERVICE_REQUEST(Type, request, sequence_number) \
RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Sending action " #Type " request"); \
if (!rcl_action_client_is_valid(action_client)) { \
return RCL_RET_ACTION_SERVER_INVALID; /* error already set */ \
return RCL_RET_ACTION_CLIENT_INVALID; /* error already set */ \
} \
RCL_CHECK_ARGUMENT_FOR_NULL(request, RCL_RET_INVALID_ARGUMENT); \
RCL_CHECK_ARGUMENT_FOR_NULL(sequence_number, RCL_RET_INVALID_ARGUMENT); \
Expand All @@ -259,7 +259,7 @@ rcl_action_client_get_default_options(void)
#define TAKE_SERVICE_RESPONSE(Type, response_header, response) \
RCUTILS_LOG_DEBUG_NAMED(ROS_PACKAGE_NAME, "Taking action " #Type " response"); \
if (!rcl_action_client_is_valid(action_client)) { \
return RCL_RET_ACTION_SERVER_INVALID; /* error already set */ \
return RCL_RET_ACTION_CLIENT_INVALID; /* error already set */ \
} \
RCL_CHECK_ARGUMENT_FOR_NULL(response_header, RCL_RET_INVALID_ARGUMENT); \
RCL_CHECK_ARGUMENT_FOR_NULL(response, RCL_RET_INVALID_ARGUMENT); \
Expand Down
Loading