Remove is_winsock_handle() and instead test if wrapping the handle in a socket.socket() works #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a socket.socket() Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
changed the title
hidmic
approved these changes
Mar 26, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
|
delete-merged-branch
bot
deleted the
ivanpauno/fix-debug-assertion-testing-winsock
branch
hidmic
pushed a commit
that referenced
this pull request
Jun 16, 2021
… a socket.socket() works (#494) Signed-off-by: Ivan Santiago Paunovic <[email protected]>
hidmic
pushed a commit
that referenced
this pull request
Jun 29, 2021
… a socket.socket() works (#494) Signed-off-by: Ivan Santiago Paunovic <[email protected]>
hidmic
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Handle signals within the asyncio loop. (#476) * Workaround asyncio signal handling on Unix (#479) * Remove is_winsock_handle() and instead test if wrapping the handle in a socket.socket() works (#494) * Close the socket pair used for signal management (#497) * Only try to wrap the fd in a socket on Windows (#498) * Bring back deprecated launch.utilities.signal_management APIs Signed-off-by: Michel Hidalgo <[email protected]> Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating failures in the nightly windows debug job I was getting a lot of debug assertions dialogs about invalid file descriptions.
I don't think this was causing the CI failures, but it was pretty anoying when debugging locally.
Testing
os.dup(os.close())had a similar issue.This seems to work fine 🤞 .