Revert "[execute_process] emulate_tty configurable and defaults to true" #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added a commit
that referenced
this pull request
Jul 24, 2019
…ts to true"" (#277) * Revert "Revert "[execute_process] emulate_tty configurable and defaults to true (#265)" (#276)" This reverts commit 15af530. * add option to strip ansi escape sequences from output in launch_testing Signed-off-by: William Woodall <[email protected]> * move registration of event handlers before including test file Signed-off-by: William Woodall <[email protected]> * replace \r\n with \n too, because you get this in emulated tty mode Signed-off-by: William Woodall <[email protected]> * fix a new test failure due a change in how pytest represents exceptions See: pytest-dev/pytest#5579 Signed-off-by: William Woodall <[email protected]> * refactor to not use YAML in eval of emulate_tty option Signed-off-by: William Woodall <[email protected]> * fix typo Signed-off-by: William Woodall <[email protected]> * refactor emulate_tty tests and test constructor argument Signed-off-by: William Woodall <[email protected]> * change default for emulate_tty to be False and fix warnings Signed-off-by: William Woodall <[email protected]>
piraka9011
pushed a commit
to aws-ros-dev/launch
that referenced
this pull request
Aug 16, 2019
…ts to true"" (ros2#277) * Revert "Revert "[execute_process] emulate_tty configurable and defaults to true (ros2#265)" (ros2#276)" This reverts commit 15af530. * add option to strip ansi escape sequences from output in launch_testing Signed-off-by: William Woodall <[email protected]> * move registration of event handlers before including test file Signed-off-by: William Woodall <[email protected]> * replace \r\n with \n too, because you get this in emulated tty mode Signed-off-by: William Woodall <[email protected]> * fix a new test failure due a change in how pytest represents exceptions See: pytest-dev/pytest#5579 Signed-off-by: William Woodall <[email protected]> * refactor to not use YAML in eval of emulate_tty option Signed-off-by: William Woodall <[email protected]> * fix typo Signed-off-by: William Woodall <[email protected]> * refactor emulate_tty tests and test constructor argument Signed-off-by: William Woodall <[email protected]> * change default for emulate_tty to be False and fix warnings Signed-off-by: William Woodall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #265