Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROS launch documentation (frontend documents) #247

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

ivanpauno
Copy link
Member

Address some comments in #163.

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Jul 26, 2019
@ivanpauno ivanpauno requested review from wjwwood and hidmic July 26, 2019 19:23
@ivanpauno ivanpauno self-assigned this Jul 26, 2019
@ivanpauno
Copy link
Member Author

Also, added <executable> example and renamed after ros2/launch_ros#47

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a couple tiny nits

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidmic's suggestions make sense, but otherwise lgtm

@ivanpauno
Copy link
Member Author

@hidmic I've corrected #163's build problems in cb2130d (tested locally) and addressed your comments in d3e9180.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 3dfa8e9 into roslaunch Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/roslaunch-corrections branch July 29, 2019 17:36
wjwwood added a commit that referenced this pull request Sep 18, 2019
* wip

* more work in progress

* more work done on the calling conventions section

* added context section, still a WIP

* updated event sections

* event filters

* fixup even handler subsection

* typos

* add subsections about the system description (language agnostic)

* Proposal for launching dynamically composable nodes (#206)

* Proposal for dynamically composed nodes

* allow multiple extra_arguments

* Allow node_name and namespace to be empty

* Human readable error message

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <[email protected]>

* Assign nodes unique ids, but still forbid duplicates

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <[email protected]>

* Update articles/150_roslaunch.md

Co-Authored-By: sloretz <[email protected]>

* Section to list

* More generic wording about container processes

* namespace -> node_namespace

* _launch/ -> ~/_container/

Signed-off-by: Shane Loretz <[email protected]>

* Propose ROS 2 launch front-end design hints. (#208)

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: ivanpauno <[email protected]>

* Adds ROS 2 launch XML format design document (#207)

Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: ivanpauno <[email protected]>

* Update ROS launch documentation (frontend documents) (#247)

Signed-off-by: ivanpauno <[email protected]>

* review fixup

Signed-off-by: William Woodall <[email protected]>

* clarify lifecycle transition due to review comment

Signed-off-by: William Woodall <[email protected]>

* provide rationale for shutdown procedure

Signed-off-by: William Woodall <[email protected]>

* Add launch XML substitution for a packages share directory (#254)

* Add launch XML substitution for a packages share directory

Rename find-pkg to find-pkg-prefix.
Add find-pkg-share substitution for the share directory.

Signed-off-by: Jacob Perron <[email protected]>

* remove some old rfc's and general cleanup for first merge

Signed-off-by: William Woodall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants