Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase pendulum_control test timeout to 60 seconds. #330

Closed
wants to merge 1 commit into from
Closed

Increase pendulum_control test timeout to 60 seconds. #330

wants to merge 1 commit into from

Conversation

clalancette
Copy link
Contributor

Under heavy IO load, aarch64 machines in particular can
take longer than 20 seconds to finish these tests. Increase
the timeout to 60 seconds to give a much larger margin.

Signed-off-by: Chris Lalancette [email protected]

I'm pretty sure that this will fix ros2/build_farmer#133, but we'll have to wait a few days for the nightlies to run to be sure.

@clalancette clalancette added the in progress Actively being worked on (Kanban column) label Apr 30, 2019
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 30, 2019
@clalancette
Increase pendulum_control test timeout to 60 seconds.
d4df2a5 
Under heavy IO load, aarch64 machines in particular can
take longer than 20 seconds to finish these tests.  Increase
the timeout to 60 seconds to give a much larger margin.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette force-pushed the increase-pendulum-timeout branch from 53f0448 to d4df2a5 Compare May 1, 2019 23:42
@sloretz
Copy link
Contributor

sloretz commented May 1, 2019

Looks like the test still fails on aarch64 https://ci.ros2.org/job/ci_linux-aarch64/3136/testReport/junit/projectroot/test_pendulum__rmw_opensplice_cpp/test_pendulum__rmw_opensplice_cpp/

I'm not sure that it is a time issue. The tests are really short on x86 with fastrtps ( I don't have opensplice installed atm). Maybe deadlock?

test_pendulum__rmw_fastrtps_cpp ..................   Passed    0.13 sec

@clalancette
Copy link
Contributor Author

I'm not sure that it is a time issue. The tests are really short on x86 with fastrtps ( I don't have opensplice installed atm). Maybe deadlock?

Huh, that's interesting. When I was debugging this by hand on the packet.net machine, I could make it fail (go over the 20 second timeout) by running stress --cpu 4 --io 4 --vm 4 in a separate terminal, but I couldn't make it fail when I increased it to 60. Not sure why that doesn't hold with the CI, but there's obviously something additional going on here. I'll try again.

@clalancette clalancette added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels May 2, 2019
@clalancette
Copy link
Contributor Author

I'm closing this out, as I'm fairly sure there are other bugs in pendulum_control causing issues. I'll reopen if this still makes sense later.

@clalancette clalancette closed this Aug 8, 2019
@clalancette clalancette deleted the increase-pendulum-timeout branch August 8, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress Actively being worked on (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux Opensplice pendulum tests fail on aarch64
2 participants
@clalancette @sloretz