Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringArray #258

Closed
wants to merge 1 commit into from
Closed

Conversation

ufrhaidar
Copy link

@ufrhaidar ufrhaidar commented Oct 3, 2024

useful sometimes.

Feels dumb to do that in local workspace, so hide it in common_interfaces.

@ufrhaidar ufrhaidar requested a review from tfoote as a code owner October 3, 2024 06:58
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought this sounds reasonable at 1st, but std_msgs does not have any array typed messages at all but MultiArray. i think this is intention to keep it in that way?

@tfoote @clalancette what do you think?

@ufrhaidar
Copy link
Author

I originally just wanted to add an array of StringArrays to a custom message. Was hoping someone would suggest a better way to achieve that like string[][] 😂

Looks like it can be added to example_msgs like the rest.

@fujitatomoya
Copy link
Collaborator

We had a discussion in PMC meeting. This is probably not gonna be taken, we try to keep the primitive types only. thank you very much for opening PR and idea.

@ufrhaidar
Copy link
Author

any reconsideration after #262 ?

@tfoote
Copy link
Contributor

tfoote commented Jan 30, 2025

That one has semantic information beyond an array of primatives. This does not. I'm asking for a rereview of that one before it's released though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants