Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the rclrs_example_msgs package to the examples folder. This package was only ever used by examples. #384

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

maspe36
Copy link
Collaborator

@maspe36 maspe36 commented Mar 30, 2024

Continuing to clean up the root level folders. This space comes at a premium and we should try to reduce the amount of noise.

Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maspe36 thanks!

@esteve esteve merged commit 0578a76 into main Mar 31, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the moved_examples_to_examples_folder branch March 31, 2024 20:45
@esteve
Copy link
Collaborator

esteve commented Mar 31, 2024

@maspe36 what do you think of eventually replacing this package with upstream's https://github.com/ros2/test_interface_files/tree/rolling ? Maybe even vendorize it. Both packages seem quite similar and it'd mean not maintaining our own package.

@maspe36
Copy link
Collaborator Author

maspe36 commented Apr 2, 2024

We could even take it a step further and move the examples out of the repo. Long term if we can get both rosidl_generator_rs and rosidl_runtime_rsupstreamed into rosidl, the only thing left in this repo would be the examples and rclrs.

rclcpp and rclpy examples are already in a different repo, and if we move our examples into a different repo, this would leave us with just rclrs, which mirrors the structure of say rclcpp.

@esteve
Copy link
Collaborator

esteve commented Apr 2, 2024

@maspe36 we don't need to move rosidl_generator_rs and rosidl_runtime_rs to another organization on Github for them to be included in the buildfarm. However, moving them to their own repositories within the ros2-rust would enable us to release them independently. We should probably do that now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants