Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx entry for lxml #6344

Merged
merged 2 commits into from
Nov 30, 2014
Merged

Add osx entry for lxml #6344

merged 2 commits into from
Nov 30, 2014

Conversation

pgorczak
Copy link
Contributor

No description provided.

@pgorczak pgorczak mentioned this pull request Nov 25, 2014
8 tasks
@wjwwood
Copy link
Member

wjwwood commented Nov 26, 2014

It's probably better to put it in the osx-homebrew.yaml file instead. Also the CI is failing because the entries are not in alphabetical order. If you could address these two things I'd be happy to merge this.

Thanks.

@trainman419
Copy link
Contributor

Bump.

It looks like @wjwwood's comments have been addressed, but this probably needs to be squashed.

P.S. - for future reference, adding commits to an issue doesn't generate notifications.

dirk-thomas added a commit that referenced this pull request Nov 30, 2014
@dirk-thomas dirk-thomas merged commit 167d804 into ros:master Nov 30, 2014
@pgorczak pgorczak deleted the patch-1 branch November 30, 2014 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants