Pylint fixes for talker.py #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iandanforth
commented
Dec 7, 2014
iandanforth
commented
- don't override built-in 'str'
- spaces around operators
- one statement per line
- whitespace cleanup
- single letter variable names are invalid, rename
- don't override built-in 'str' - spaces around operators - one statement per line - whitespace cleanup - single letter variable names are invalid, rename
|
When this is merged http://wiki.ros.org/ROS/Tutorials/WritingPublisherSubscriber%28python%29 will need to be updated to reflect the changes. |
|
Thanks, wiki page updated accordingly: http://wiki.ros.org/action/diff/rospy_tutorials/Tutorials/WritingPublisherSubscriber?action=diff&rev1=118&rev2=119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.