Python 3 compatibility #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
Test passed. |
|
Zero regressions with Python 2. @wjwwood Please review. |
| param_key = args[1] | ||
| param_val = args[2] | ||
|
|
||
| val = compute_param_updates(reg, param_key, param_val) |
There was a problem hiding this comment.
This change doesn't seem to be equivalent, it seems as though reg would have not been passed before. Is this right?
There was a problem hiding this comment.
Yeah, looks pretty weird. But actually the test was not using the API as specified before and did not pass in a Registrations instance as it should be. So this patch should be a cleanup.
|
Other than the comment +1 |
Closed
rsinnet
pushed a commit
to MisoRobotics/ros_comm
that referenced
this pull request
Jun 19, 2017
Python 3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.