Foxy: Restore tf frame prefix support for ROS 2 (#159) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick and dirty frame_prefix support for foxy Also make it so we don't handle / specially. Add in tests and documentation as well. Co-authored-by: Chris Lalancette <[email protected]>
|
@sloretz Friendly ping on this one; this is the last backport of this feature, then we'll have it in Foxy, Galactic, and Rolling. |
sloretz
approved these changes
Aug 3, 2021
|
CI:
|
|
The warnings on Windows are well-known, and not because of this PR. I'm going to go ahead and merge this and do a release for Foxy. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick and dirty frame_prefix support for foxy
Also make it so we don't handle / specially.
Add in tests and documentation as well.
Co-authored-by: Chris Lalancette [email protected]
This is an ABI compatible version of #159 for Foxy.