-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement tf_prefix in Noetic exactly as it was in Melodic #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one nit, but otherwise, this is a really good implementation. One other issue is that CI seems to be failing. I'm going to approve anyway, assuming that you'll fix both of these issues before merging.
Any chances this will be merged soon ? It has been more than a year since the issue has been raised and proposal have been made. I think this functionality is useful and many people would love to use this again. CI on focal fails because it failed to open the bag file. Does it ring a bell ? |
Any updates on a timeline for when this will be merged? |
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
95681e8
to
0a633e5
Compare
Signed-off-by: Shane Loretz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me assuming CI goes green.
In ROS Noetic, support for TF prefixing with robot_state_publisher was removed. However, it was re-implemented in this PR a few months ago: ros/robot_state_publisher#169
In ROS Noetic, support for TF prefixing with robot_state_publisher was removed. However, it was re-implemented in this PR a few months ago: ros/robot_state_publisher#169
This is an alternative to #139. The goal of this PR is to make ROS Noetic
robot_state_publisher
behave the same as the ROS Melodic version. It's different from #139 in these ways:tf_prefix
While it doesn't break ABI, it effectively breaks using
JointStateListener
with a customRobotStatePublisher
. In this PRJointStateListener
calls non-virtual versions ofpublishFixedTransforms()
andpublishTransforms()
. Users who subclassRobotStatePublisher
, overridepublishFixedTransforms()
orpublishTransforms()
, and pass their subclass instance to a vanillaJointStateListener
will observe their callbacks never being called.Note: ROS 2
robot_state_publisher
uses a different approach. It has a parameterframe_prefix
that only appends a string to the frame name - no tf1 style special handling of slashes. See #159 for details.