Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for subclassing #25

Closed
peci1 opened this issue Feb 24, 2015 · 4 comments
Closed

Missing support for subclassing #25

peci1 opened this issue Feb 24, 2015 · 4 comments
Assignees

Comments

@peci1
Copy link

peci1 commented Feb 24, 2015

I'd like to customize the behavior of both joint_state_listener and robot_state_publisher, but the interface doesn't allow for that. In joint_state_listener, all the methods are private. And both in joint_state_listener and robot_state_publisher, no method is virtual to support subclassing. Furthermore, there's no way to "plug in" a different class than RobotStatePublisher to the joint_state_listener.

I'd like to ask you to make this package more friendly for subclassing.

If you'd like to know my motivation for subclassing - in our project, we're forced to fake some fixed joints by prismatic joints with zero limits. And I'd like the robot_state_publisher to recognize these fake fixed joints as fixed and to treat them so. And I'd also like to use the /tf_static topic for publishing the transforms for fixed joints.

@jacquelinekay
Copy link
Contributor

hey @peci1,

it's a bit late, but I can look into adding better support for subclassing in Kinetic.

@jacquelinekay jacquelinekay self-assigned this Jan 24, 2016
@peci1
Copy link
Author

peci1 commented Jan 25, 2016

@jacquelinekay +1

@peci1
Copy link
Author

peci1 commented May 23, 2016

Thanks ;) Is there a possibility to get it also merged into indigo-devel?

@jacquelinekay
Copy link
Contributor

I believe it technically isn't an API change and could go into Indigo, but it will definitely break ABI. I will think about it.

clalancette pushed a commit that referenced this issue Oct 8, 2019
This results in a failure when someone adds
find_package(robot_state_publisher) to their CMakeLists.txt.

You get the error
'robot_state_publisher' exports 'robot_state_publisher' which
can't be found.

Signed-off-by: Shane Loretz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants