Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 compatibility #26

Closed
wants to merge 1 commit into from
Closed

python 3 compatibility #26

wants to merge 1 commit into from

Conversation

dirk-thomas
Copy link
Member

No description provided.

@esteve
Copy link
Member

esteve commented Nov 13, 2014

test.test_genpy_generator.test_array_serializer_generator_numpy and test.test_genpy_generator.test_array_serializer_generator don't pass on my machine with Python 2.7, any suggestion? Is there a way to test this with Python 3 as well?

https://gist.github.com/esteve/0e0e9f46506efd59962f

@dirk-thomas
Copy link
Member Author

Since this PR does not work 100% on both Python 2 and 3 it has not been merged yet.

@sloretz
Copy link
Contributor

sloretz commented Jan 24, 2020

@dirk-thomas friendly ping. This looks pretty stale. Is it still relevant?

@dirk-thomas
Copy link
Member Author

I can't tell if this change is necessary anymore. Until now we have done all Python 3 testing without it with no problems. So I would like to see an example which fails without this patch / works with it.

@dirk-thomas
Copy link
Member Author

I will close this for now due to the age / inactivity and uncertainty if any of the changes is still necessary. The upcoming ROS Noetic is the first ROS distro officially targeting Python 3. If the problem still exists in Noetic please open a new ticket with steps to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants