Skip to content

Add buildtool depend on setuptools #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 17, 2020

Requires ros/rosdistro#23532
See http://build.ros.org/job/Ndev__genmsg__ubuntu_focal_amd64/2/console

This seems to be python3 specific. I don't see a python-distutils package for python 2 in Debian or Ubuntu. It looks like every package importing distutils in its setup.py will need to depend on this. Maybe catkin should export the dependency instead?

@sloretz sloretz requested a review from dirk-thomas January 17, 2020 00:17
@dirk-thomas
Copy link
Member

How about changing the import to setuptools instead which has been the Python recommendation for a long time (and add the necessary dependency to the manifest)?

@sloretz
Copy link
Contributor Author

sloretz commented Jan 17, 2020

How about changing the import to setuptools instead

Is 6b4755f what you had in mind?

@dirk-thomas
Copy link
Member

It likely needs a Python 2 dependency for setuptools too.

Signed-off-by: Shane Loretz <[email protected]>
@sloretz
Copy link
Contributor Author

sloretz commented Jan 17, 2020

It likely needs a Python 2 dependency for setuptools too.

e18244b

@dirk-thomas dirk-thomas merged commit 643b834 into ros:kinetic-devel Jan 17, 2020
@dirk-thomas
Copy link
Member

(Doh, I should have changed the title before the merge...)

@sloretz sloretz changed the title Add buildtool depend on distutils Add buildtool depend on setuptools Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants