Find Poco library using upstream CMake configuration. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in the FindPoco module from cmake_modules causes incorrect linking in Debug configurations. I haven't decided if this is a straw man or not since I'm not sure what we gain or lose by not using the module from cmake_modules.
dirk-thomas
reviewed
Feb 15, 2019
|
CI informs me that this won't be a complete solution as Debian Stretch's libpoco-dev package doesn't contain CMake configuration. |
|
+1 to getting rid of stuff in |
We were using this only for Poco. As of Debian Buster and Ubuntu Bionic libpoco-dev provides the necessary CMake configuration.
|
While this would be the preferred solution to #117 it won't work for Melodic. I've added a commit that completes this PR so it can be considered in the future once support for Stretch is dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the FindPoco module from cmake_modules causes incorrect linking in Debug configurations.
I haven't decided if this is a straw man or not since I'm not sure what we gain or lose by not using the module from cmake_modules.
This is one possible way to resolve #117 but I'd like input from someone like @wjwwood before I decide whether this is a good idea or not.