Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to truly enable antialiasing. The only piece of code that seemed related to it was here, but changing the value did not seem to have any effect. I added the entry to the proper dictionary, and used a value of 4 which is quite common (cf. Gazebo). Talking about Gazebo, they also added antialiasing to their
Camera
class, which for instance shares code similar toSelectionManager::setDepthTextureSize
for creatingOgre::RenderTexture
objects. This may not be relevant at all to add FSAA here, but it may be the perfect time to check similar parts of the code where antialiasing could improve the rendering.As for the previous
"FSAA"
key in the other dictionary, if it is in fact useless, it may be worth removing, but since Gazebo also has it, I only updated its value.Comparison before/after: