support multiple material for one link #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll back port this for jade (or forward port it from the indigo pr). |
This was referenced May 2, 2017
wjwwood
pushed a commit
that referenced
this pull request
Jun 5, 2017
|
Backported in #1110 |
wjwwood
added a commit
that referenced
this pull request
Jun 5, 2017
* Add fullscreen option. (#1017) * urdfdom compatibility (#1064) * Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package * Update display if empty pointcloud2 is published (#1073) Do not show last point cloud any more, if published point cloud message does not contain any points * Correctly scale the render panel on high resolution displays (#1078) * support multiple material for one link (#1079) * Fixed duplicate property name for Path colors (#1089) See issue #1087. * fix type error in newer versions of urdf (#1098) * Use unique material names for robot links. (#1102) * avoid C++11 feature for back port to indigo
Merged
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Oct 29, 2018
In urdf::Link, only the first visual's material comprises actual color values, all others only have the name. Thus to correctly show the color of all visuals, we need to search for the first visual with given material name, much like ros-visualization#1079 has done. If urdf parser is fixed, this work-around can be removed.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Feb 10, 2019
In urdf::Link, only the first visual's material comprises actual color values, all others only have the name. Thus to correctly show the color of all visuals, we need to search for the first visual with given material name, much like ros-visualization#1079 has done. If the urdfdom fix (ros/urdfdom#114) is released, this work-around can be reverted.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Feb 17, 2019
This reverts commit 3f1b388.
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Feb 17, 2019
alternative implementation for ros-visualization#1079
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Feb 17, 2019
In urdf::Link, only the first visual's material comprises actual color values, all others only have the name. Thus to correctly show the color of all visuals, we need to search for the first visual with given material name, much like ros-visualization#1079 has done. If the urdfdom fix (ros/urdfdom#114) is released, this work-around can be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is rewrited version of #812
we'll get
with this urdf