Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL distros and Ubuntu Bionic #592

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Jul 8, 2023

  • Drop support for Melodic and Foxy, since they are now EOL
  • Drop support for Ubuntu Bionic, since there is no longer an active ROS distro for it (used to be Melodic)
  • Since there is no longer (and never will be) a common Ubuntu version for a ROS 1 distro and a ROS 2 distro, remove the test_multiple_ros_installations CI test job
  • Update Windows binaries for Humble
  • Update distros in README

@christophebedard christophebedard requested a review from a team as a code owner July 8, 2023 20:56
@christophebedard christophebedard self-assigned this Jul 8, 2023
@christophebedard christophebedard requested review from emersonknapp and MichaelOrlov and removed request for a team July 8, 2023 20:56
@christophebedard christophebedard force-pushed the christophebedard/eol-distros branch from 987ffc3 to d11129a Compare July 8, 2023 21:01
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c3a899) 93.18% compared to head (69c3b23) 93.18%.

❗ Current head 69c3b23 differs from pull request most recent head 263c477. Consider uploading reports for the commit 263c477 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files           8        8           
  Lines         176      176           
  Branches       17       17           
=======================================
  Hits          164      164           
  Misses         12       12           
Impacted Files Coverage Δ
src/package_manager/apt.ts 93.75% <ø> (ø)
src/setup-ros-windows.ts 78.12% <ø> (ø)
src/setup-ros-linux.ts 97.72% <100.00%> (ø)
src/utils.ts 90.32% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as long as Foxy/Melodic users can keep using old releases of this action to build their projects

@christophebedard
Copy link
Member Author

christophebedard commented Jul 10, 2023

Yep, users can just keep using an older version of setup-ros/action-ros-ci, but they of course won't get new features.

@christophebedard christophebedard merged commit 9b16a33 into master Jul 10, 2023
@christophebedard christophebedard deleted the christophebedard/eol-distros branch July 10, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants