Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDF namespacing for Video Plugin #546

Conversation

davetcoleman
Copy link
Collaborator

@davetcoleman davetcoleman commented Feb 19, 2017

Fixes video plugin for Kinetic, and removes the following warnings with Baxter/other ROS-robots:

ros.gazebo_plugins.video: GazeboRosVideo plugin missing <robotNamespace>, defaults to "".
ros.gazebo_plugins.video: GazeboRosVideo Plugin (ns = ) missing <topicName>, defaults to "image_raw".
ros.gazebo_plugins.video: GazeboRosVideo Plugin (ns = ) missing <height>, defaults to 240.
ros.gazebo_plugins.video: GazeboRosVideo Plugin (ns = ) missing <width>, defaults to 320

This does not fix the related issue reported on bitbucket for the video plugin

This fix initially created and tested by @IanTheEngineer
This PR is sponsored by Vicarious

@davetcoleman
Copy link
Collaborator Author

I've finally figured out why they set this issue as resolved on Bitbucket - the warnings go away if you switch to the OSRF debians and the latest 7.5.0 version of Gazebo instead of the Ubuntu universe 7.0.0 version.

Still, this PR is backwards compatible and provides support for both 7.0 and 7.5, so I think it should be merged.

@piyushk
Copy link
Contributor

piyushk commented Feb 21, 2017

I can confirm that this works as expected, and allows setting plugin parameters again.

Thanks @davetcoleman!

@IanTheEngineer
Copy link
Contributor

+1 Thanks for taking the time to apply the patch Dave.

@j-rivero
Copy link
Contributor

I can confirm that this works as expected, and allows setting plugin parameters again.

If we have a confirmation, @davetcoleman feel free to merge. Thanks guys.

@davetcoleman davetcoleman merged commit 0843acc into ros-simulation:kinetic-devel Feb 21, 2017
@davetcoleman
Copy link
Collaborator Author

Thanks @IanTheEngineer for initially creating this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants