Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dock orientation while moving backwards #4530

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix dock orientation while moving backwards #4530

merged 1 commit into from
Jul 22, 2024

Conversation

ajtudela
Copy link
Contributor

@ajtudela ajtudela commented Jul 9, 2024 •
edited by SteveMacenski
Loading

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4527 open-navigation/opennav_docking#51
Primary OS tested on Ubuntu 22.04
Robotic platform tested on Morphia robot, Gazebo classic)
Does this PR contain AI generated software? No)

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@ajtudela ajtudela force-pushed the fix_bacward_dock branch from 94c1b1e to 940322a Compare July 9, 2024 22:18
@SteveMacenski
Copy link
Member

If Fergs can't give this a review in a couple of days, I'll merge in this and the opennav_docking version of this PR if you ping me again after Thursday!

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files Coverage Δ
...av2_docking/opennav_docking/src/docking_server.cpp 89.76% <50.00%> (-0.21%) ⬇️

... and 2 files with indirect coverage changes

@ajtudela ajtudela requested a review from SteveMacenski July 22, 2024 18:34
@SteveMacenski SteveMacenski merged commit f73fa24 into ros-navigation:main Jul 22, 2024
10 of 11 checks passed
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
@ajtudela @mergify
Fix dock orientation while moving backwards (#4530)
a349193 
Signed-off-by: Alberto Tudela <[email protected]>
(cherry picked from commit f73fa24)
@mergify mergify bot mentioned this pull request Jul 22, 2024
Merged
7 tasks
SteveMacenski pushed a commit that referenced this pull request Jul 22, 2024
@mergify @ajtudela
Fix dock orientation while moving backwards (#4530) (#4553)
026c778 
Signed-off-by: Alberto Tudela <[email protected]>
(cherry picked from commit f73fa24)

Co-authored-by: Alberto Tudela <[email protected]>
@ajtudela ajtudela deleted the fix_bacward_dock branch July 22, 2024 21:30
masf7g pushed a commit to quasi-robotics/navigation2 that referenced this pull request Oct 23, 2024
@ajtudela @masf7g
Fix dock orientation while moving backwards (ros-navigation#4530)
3dbd093 
Signed-off-by: Alberto Tudela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@mikeferguson mikeferguson Awaiting requested review from mikeferguson

Assignees
No one assigned
Labels
backport-jazzy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajtudela @SteveMacenski