Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong Map Pointer (#3311) #3314

Closed
wants to merge 1 commit into from
Closed

Fix Wrong Map Pointer (#3311) #3314

wants to merge 1 commit into from

Conversation

borongyuan
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #3311
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo Simulation of TurtleBot3, Our Own Robot)

Description of contribution in a few bullet points

Not assigning fixed map pointer to particle filter, using latest when resample.

Description of documentation updates required from your changes


Future work that may be required in bullet points

I only made this fix for Foxy branch. Other branches may have the same issue. I also have Humble environment, but I haven't had much time lately to check and test. It would be great if you could help to check.

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Not assigning fixed map pointer to particle filter, using latest when resample.

Signed-off-by: Borong Yuan <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

@borongyuan, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @foxy-devel, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

@borongyuan, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant