Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gradient layer costmap2d plugin tutorial #1541

Merged

Conversation

AlexeyMerzlyakov
Copy link
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses #1533
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo simulation of TB3 waffle

Description of contribution in a few bullet points

  • Adding tutorial: Writing a new Costmap2D plugin: gradient layer

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #1541 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
+ Coverage    37.2%   37.24%   +0.03%     
==========================================
  Files         226      226              
  Lines       11807    11807              
  Branches     5135     5135              
==========================================
+ Hits         4393     4397       +4     
+ Misses       4014     4013       -1     
+ Partials     3400     3397       -3
Flag Coverage Δ
#project 37.24% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
nav2_navfn_planner/src/navfn.cpp 46.33% <0%> (ø) ⬆️
nav2_map_server/src/map_server.cpp 42.85% <0%> (ø) ⬆️
nav2_util/test/test_actions.cpp 42.66% <0%> (+0.45%) ⬆️
nav2_voxel_grid/src/voxel_grid.cpp 67.28% <0%> (+2.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64eb5a0...0c4000e. Read the comment docs.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates, this looks really good. My requests are just grammar and formatting. For anything I could just give a suggested edit, you can merge directly in browser. I couldn't do that for the tables though.

Looks great. After those updates we can merge this in. Thanks for making a very thorough tutorial, this will do alot of good. You explained things very well.

@SteveMacenski
Copy link
Member

You've inspired me to get to writing a controller and planner plugin tutorial as well. I'll play around with that this weekend

@AlexeyMerzlyakov
Copy link
Collaborator Author

Thank you for very positive feedback! Everything is seems to be done.

@SteveMacenski SteveMacenski merged commit f062453 into ros-navigation:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants