-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding gradient layer costmap2d plugin tutorial #1541
adding gradient layer costmap2d plugin tutorial #1541
Conversation
sphinx_doc/tutorials/docs/sources/Writing_new_Costmap2D_plugin/gradient_layer.cpp
Outdated
Show resolved
Hide resolved
sphinx_doc/tutorials/docs/sources/Writing_new_Costmap2D_plugin/gradient_layer.cpp
Outdated
Show resolved
Hide resolved
sphinx_doc/tutorials/docs/sources/Writing_new_Costmap2D_plugin/gradient_layer.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexey Merzlyakov <[email protected]>
e2e91b7
to
0b6c748
Compare
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
+ Coverage 37.2% 37.24% +0.03%
==========================================
Files 226 226
Lines 11807 11807
Branches 5135 5135
==========================================
+ Hits 4393 4397 +4
+ Misses 4014 4013 -1
+ Partials 3400 3397 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small updates, this looks really good. My requests are just grammar and formatting. For anything I could just give a suggested edit, you can merge directly in browser. I couldn't do that for the tables though.
Looks great. After those updates we can merge this in. Thanks for making a very thorough tutorial, this will do alot of good. You explained things very well.
You've inspired me to get to writing a controller and planner plugin tutorial as well. I'll play around with that this weekend |
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Co-Authored-By: Steve Macenski <[email protected]>
Thank you for very positive feedback! Everything is seems to be done. |
Basic Info
Description of contribution in a few bullet points