Drop ROS Python package dependencies in debs #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When our Python packages are split into a separate `-modules` subpackage, it appears that the pattern is to retain the package distribution information in the main package, which contains the scripts. When our packages take dependencies on only the `-modules` subpackage, they need to omit the Python dependencies to prevent `pkg_resources` from looking for those missing packages. Instead, we rely on apt and dpkg to ensure that the dependencies are present. This shouldn't have any affect on non-debian installation of rosdep.
|
Here's a similar pattern in |
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 44 44
Lines 3362 3362
=======================================
Hits 2516 2516
Misses 846 846 Continue to review full report at Codecov.
|
clalancette
approved these changes
Jun 24, 2022
russkel
pushed a commit
to Greenroom-Robotics/rosdep
that referenced
this pull request
Jun 27, 2022
When our Python packages are split into a separate `-modules` subpackage, it appears that the pattern is to retain the package distribution information in the main package, which contains the scripts. When our packages take dependencies on only the `-modules` subpackage, they need to omit the Python dependencies to prevent `pkg_resources` from looking for those missing packages. Instead, we rely on apt and dpkg to ensure that the dependencies are present. This shouldn't have any affect on non-debian installation of rosdep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When our Python packages are split into a separate
-modulessubpackage, it appears that the pattern is to retain the package distribution information in the main package, which contains the scripts.When our packages take dependencies on only the
-modulessubpackage, they need to omit the Python dependencies to preventpkg_resourcesfrom looking for those missing packages. Instead, we rely on apt and dpkg to ensure that the dependencies are present.This shouldn't have any affect on non-debian installation of rosdep.
Fixes #886