Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark linter tests and tests which require network #884

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 23, 2022

Marking tests appropriately will allow us to be more selective about what tests are run.

Marking tests appropriately will allow us to be more selective about
what tests are run.
@cottsay cottsay requested a review from nuclearsandwich June 23, 2022 18:33
@cottsay cottsay self-assigned this Jun 23, 2022
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I didn't perform offline tests to see if these markers are comprehensive they do appear applied correctly where used. Thanks for the improvement!

@cottsay cottsay merged commit 275cdeb into master Jun 24, 2022
@cottsay cottsay deleted the cottsay/pytest-mark branch June 24, 2022 02:30
russkel pushed a commit to Greenroom-Robotics/rosdep that referenced this pull request Jun 27, 2022
…#884)

Marking tests appropriately will allow us to be more selective about
what tests are run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants