Declare test dependencies in [test] extra #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the 'mock' dependency conditional, now that this package supports using unittest.mock.
cottsay
force-pushed
the
cottsay/extras-test
branch
from
339b60e to
cd40f4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 44 44
Lines 3360 3360
=======================================
Hits 2514 2514
Misses 846 846 Continue to review full report at Codecov.
|
nuclearsandwich
approved these changes
Jun 24, 2022
russkel
pushed a commit
to Greenroom-Robotics/rosdep
that referenced
this pull request
Jun 27, 2022
Also make the 'mock' dependency conditional, now that this package supports using unittest.mock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formally declaring the test dependencies somewhere is a good idea, and allows tools like
colconto discover them.['extras_require']['test'] is where we put these dependencies in colcon itself, but there doesn't appear to be a strong consensus among the packaging community regarding where to list these, and many options aren't compatible with python 2, which is still supported in this package. This option seems to meet all of our needs.
Also make the 'mock' dependency conditional, now that this package supports using unittest.mock.