keys: add support for --ignore-src #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `--ignore-src` is only supported by the `check` and `install` verbs. Add support in the `keys` verb as well, displaying dependencies that are not already satisfied by other packages in the workspace. Resolve ros-infrastructure#685 Signed-off-by: Kyle Fazzari <[email protected]>
kyrofa
force-pushed
the
feature/685/keys_ignore_src
branch
from
0239440 to
e9b3a56
Compare
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 75.46% 75.47% +<.01%
==========================================
Files 32 32
Lines 2967 2968 +1
==========================================
+ Hits 2239 2240 +1
Misses 728 728
Continue to review full report at Codecov.
|
|
@nuclearsandwich curious to get your thoughts on this. |
jacobperron
approved these changes
Jun 11, 2019
cottsay
approved these changes
Jun 11, 2019
|
Hey @tfoote, any chance we can get this released? We're carrying some patches that we can drop once that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
--ignore-srcis only supported by thecheckandinstallverbs. This PR resolves #685 by adding support in thekeysverb as well, displaying dependencies that are not already satisfied by other packages in the workspace.