Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pulp support and remove pulp support configuration and dependencies. #135

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

nuclearsandwich
Copy link
Collaborator

This is a rebase of #118 with some modifications:

recipes/repo.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not detect any big problem, just a check on a system path in a comment I left before.

@nuclearsandwich nuclearsandwich force-pushed the nuclearsandwich/drop-pulp branch from 0c576ed to 2824251 Compare September 26, 2024 23:18
@nuclearsandwich
Copy link
Collaborator Author

nuclearsandwich commented Sep 26, 2024

In addition to the CI checks, I also confirmed that this branch can be converged on top of 0.5.1 validating it for inclusion in a 0.6.0 release.

This also converges cleanly on 0.5.0 which means that we could technically release it in a 0.5.2 although since the scope of this change is to remove an entire feature (that was switched off by default in 0.5.1 I think a tick-tock approach across two major versions is warranted.

@nuclearsandwich nuclearsandwich merged commit 1e74409 into latest Sep 26, 2024
4 checks passed
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/drop-pulp branch September 26, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants