Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleep after starting thread to fix flaky tests #235

Merged

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Dec 13, 2024

Fixes #198
I've tested it running it with arg --retest-until-fail 200

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (e58c7ad) to head (44ef4a5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files           7        7           
  Lines         436      436           
  Branches       72       72           
=======================================
  Hits          319      319           
  Misses         73       73           
  Partials       44       44           
Flag Coverage Δ
unittests 73.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a try :)

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. label Dec 13, 2024
@christophfroehlich christophfroehlich merged commit 78f0372 into ros-controls:master Dec 13, 2024
19 checks passed
@saikishor saikishor deleted the fix/flaky/tests branch December 13, 2024 19:39
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests of AsyncFunctionHandlerTest
3 participants