Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting_started.rst #377

Merged
merged 12 commits into from
Jan 19, 2025

Conversation

christymanthara
Copy link
Contributor

Added the code block for the binary installation packages.

Added the code block for the binary installation packages.
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely true, apt is available on ubuntu only. As REP-2000 states, there are more platforms with released binary packages. See also docs.ros.org

Made specific installation instructions
Copy link
Contributor Author

@christymanthara christymanthara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes as per the suggestions

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's clean that up a bit, so we can backport it to humble+jazzy as well.

doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
doc/getting_started/getting_started.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author

@christymanthara christymanthara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Feedback

@mergify mergify bot mentioned this pull request Jan 17, 2025
@christymanthara
Copy link
Contributor Author

made changes. please check

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pre-commit errors. Run pre-commit run --all locally and push the changes.

@christophfroehlich
Copy link
Contributor

@Mergifyio backport rolling humble

Copy link
Contributor

mergify bot commented Jan 17, 2025

backport rolling humble

✅ Backports have been created

Copy link
Contributor Author

@christymanthara christymanthara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran pre-commit run --all locally and no errors found

@christymanthara
Copy link
Contributor Author

pull request to jazzy branch.

Copy link
Contributor Author

@christymanthara christymanthara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fixes in the rst file

@christophfroehlich christophfroehlich merged commit cc466d2 into ros-controls:jazzy Jan 19, 2025
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 19, 2025
(cherry picked from commit cc466d2)
mergify bot pushed a commit that referenced this pull request Jan 19, 2025
(cherry picked from commit cc466d2)
christophfroehlich pushed a commit that referenced this pull request Jan 19, 2025
(cherry picked from commit cc466d2)

Co-authored-by: CHRISTY JO MANTHARA <[email protected]>
christophfroehlich pushed a commit that referenced this pull request Jan 19, 2025
(cherry picked from commit cc466d2)

Co-authored-by: CHRISTY JO MANTHARA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants