Development #745
Closed
Development #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siemens CSA header, to prevent an overflow issue, where length of strcat(outStr, tmpstr) became 1 byte too long as tmpstr is of length 2.
support for writing out the adFree and alFree blocks for the FWF sequence from Lund. Tools to use the output can be found at https://github.com/markus-nilsson/fwf_header_tools/tree/master/siemens#alternative-approach
|
@markus-nilsson I have integrated your PR into the development branch, but I do not have concrete data to validate this solution. To ensure good regressions are not introduced, new features need a validation dataset like this one that provides DICOMs as well as the correct BIDS solution. |
yarikoptic
added a commit
to neurodebian/dcm2niix
that referenced
this pull request
Apr 29, 2024
* tag 'v1.0.20240202': (135 commits) Update submodules Refactor (rordenlab#791) gantry tilt tolerance (rordenlab#791) GE step description (rordenlab#790) PatientOrient -> Patient Position (rordenlab#786) Prevent shell expansion (rordenlab#789) Replace presumably accidental bitwise AND operations Update JasPer API calls for compatibility with newer versions of the library Update divest logic, reducing duplication and supporting new mode of operation Fix PhaseEncodingDirectionDisplayed for GE Update date GE Diffusion issue rordenlab#777 minor GE Diffusion issue rordenlab#777 Kludge for issue 775 (rordenlab#775) add docstrings better python wrapper I/O issue 769: Mildly relax the check for bvec components > 1. PRs (rordenlab#745; rordenlab#768) Edge cases (rordenlab#763, rordenlab#749) Code spell ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: Changing maximal length of string read from Siemens CSA header, to prevent an overflow issue, where length of strcat(outStr, tmpstr) became 1 byte too long as tmpstr is of length 2.
(We have files where the WipMemBlock is even longer than kDICOMStrLarge and this caused an overflow which nulled pulseSequenceDetails, causing further problems downstream)
Second commit: Adding support to write out WipMemBlock strings longer than 256 bytes, and adding support to write out all alFree/adFree items of the SiemensCSAHeader for diffusion MRI data acquired with the free waveform patch from Lund University. Info on how to use the resulting JSON file can be found here: https://github.com/markus-nilsson/fwf_header_tools/tree/master/siemens#alternative-approach
(Generated a pull request for this to the master branch last Friday, sorry for that misstake)