Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new chromedriver location (extended) #39

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fix for new chromedriver location (extended) #39

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bc8eb6a
Partial work towards Google Chrome for Testing update.
dmurdoch Aug 24, 2023
51f576b
First pass at fix for new chromedriver location
dmurdoch Sep 23, 2023
82af6b6
Merge branch 'master' into pr/35
jonathanvoelkle Oct 23, 2023
3d6fed8
fix dependencies
jonathanvoelkle Oct 23, 2023
2852533
Fix Chrome errors
ashbythorpe Oct 25, 2023
e8014d8
Document
ashbythorpe Oct 25, 2023
564c932
Use rlang::try_fetch() to display errors
ashbythorpe Oct 25, 2023
e184b6d
Fix platform pattern matching
ashbythorpe Oct 25, 2023
45b0c5c
Revert "Fix platform pattern matching"
ashbythorpe Oct 25, 2023
4fdb9e7
Fix chromedriver.yml
ashbythorpe Oct 25, 2023
bc68bd9
Update mac_machine() to include new Mac platforms
ashbythorpe Oct 25, 2023
460669f
Pattern match Windows correctly
ashbythorpe Oct 25, 2023
d81ae6e
Use workaround for tapply() on older versions or R
ashbythorpe Oct 25, 2023
0476486
Actually use tapply_identity()
ashbythorpe Oct 25, 2023
26115d1
Make sure chrome() works for old version
ashbythorpe Oct 25, 2023
2407d5d
Make sure Windows pattern matches correctly with old Chrome
ashbythorpe Oct 25, 2023
c1c874f
Document and clean up functions
ashbythorpe Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fix platform pattern matching" 
This reverts commit e184b6d.
  • Loading branch information
@ashbythorpe
ashbythorpe committed Oct 25, 2023
commit 45b0c5cd0189569a7de46cf5c1aab7ef10ea40dc
1 change: 1 addition & 0 deletions R/predl_chrome_for_testing.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ predl_chrome_for_testing <- function(url, platform, history,
}
}
extracted <- do.call(rbind, lapply(ver_data, unwrap))
print(extracted)
app_links <- tapply(extracted, extracted$platform, identity)
has_platform <- vapply(
names(app_links),
Expand Down