Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add babeldown tech note #633

Merged
merged 29 commits into from
Sep 26, 2023
Merged

Add babeldown tech note #633

merged 29 commits into from
Sep 26, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Sep 5, 2023

No description provided.

@maelle maelle requested a review from yabellini September 5, 2023 10:07
yabellini
yabellini reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only changed the .Rmd

content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
@steffilazerte steffilazerte added the blog post Blog posts to be published when merged label Sep 15, 2023
steffilazerte
steffilazerte reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@steffilazerte steffilazerte left a comment •
edited by maelle
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @maelle, this is amazing!

For the most part, just some slight rephrasing suggestions and a bit of tweaking of the headings in the Translation section (I think you can make it two upper level sections, so the sub headings aren't so small, see what you think). I also suggest a bit more parallelism between the image/code sections as they are supposed to show the same process, just in different ways, so the information should be the same.

Really cool work you've done!

  • post follows Content Guidelines
  • post follows Style Guide
  • title is in Title Case
  • publication date is ok --> Go for Tues Sept 26th, if that's not too soon, otherwise Thurs Sept 28th or Tues Oct 3rd (I recommend so not too close to the weekends, but otherwise pick a date that works for you!)
  • alternative text of images is informative -> You're very good at Alt text! I'm taking notes. I know in theory but really like how you've done it here.
  • author metadata is provided with correct folder name
  • html not included in pull request of Rmd post
  • I ran roblog::ro_lint_md() on index.md
  • I ran roblog::ro_check_urls() on index.md
  • I ran a spell-check on index.md
  • YAML subject tags are ok ("tech notes" for tech notes; "community" for non-staff non-editor)
  • YAML field 'preface' is present if necessary

content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
content/blog/2023-09-05-how-to-translate-a-hugo-blog-post-with-babeldown/index.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Sep 22, 2023

Thanks so much @steffilazerte!

maelle and others added 5 commits September 22, 2023 09:21
@maelle
link
8d44637
@maelle
add placeholders for translation
ca3d9a5
@maelle
Add automatic French translation (#645)
48c6967
@maelle
translate tag
d6924e5
@maelle @yabellini
add automatic translation (#647)
936bc3e 
* add automatic translation

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Edit names of branches to match diagrams.

* Update content/blog/2023-09-26-how-to-translate-a-hugo-blog-post-with-babeldown/index.es.md

* Update content/blog/2023-09-26-how-to-translate-a-hugo-blog-post-with-babeldown/index.es.md

---------

Co-authored-by: Yanina Bellini Saibene <[email protected]>
@maelle maelle merged commit c218b15 into main Sep 26, 2023
@maelle maelle deleted the babeldown-hugo branch September 26, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yabellini yabellini yabellini left review comments

@steffilazerte steffilazerte steffilazerte left review comments

Assignees
No one assigned
Labels
blog post Blog posts to be published when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maelle @yabellini @steffilazerte