Address feedback from @ccamara at https://github.com/ropensci/software-review/issues/633#issuecomment-2160182185 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl + Shift + B in Rstudio doesn't install vignettes Feedback from @ccamara at https://github.com/ropensci/software-review/issues/633#issuecomment-2121192135https://github.com/ropensci/software-review/issues/633#issuecomment-2160182185
Better package description Move examples from README to the Get started Vignette Feedback from @ccamara at https://github.com/ropensci/software-review/issues/633#issuecomment-2121192135https://github.com/ropensci/software-review/issues/633#issuecomment-2160182185
|
Would you like to review, @ccamara ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 23 23
Lines 2109 2109
=======================================
Hits 1959 1959
Misses 150 150 ☔ View full report in Codecov by Sentry. |
29 tasks
jmaspons
changed the title
Co-authored-by: Joan Maspons <[email protected]>
|
Looks great to me, @jmaspons . Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve README and move examples to an introductory vignette