Improve tests and fixes

TODO: osm_full_object() lost last object in format = R (test-elements.R:611)

R/osm_get_user_details.R

@@ -66,11 +66,39 @@ osm_get_user_details <- function(user_id, format = c("R", "xml", "json")) {
   if (length(user_id) == 1) {
     out <- tryCatch( # ! HTTP 404 Not Found. Different from osm_details_users()
       osm_details_user(user_id = user_id, format = format),
-      error = function(e) empty_user()
+      error = function(e) {
+        switch(format,
+          R = empty_user(),
+          xml = empty_usr_xml(),
+          json = empty_usr_json()
+        )
+      }
     )
   } else {
     out <- osm_details_users(user_ids = user_id, format = format)
   }
 
   return(out)
 }
+
+
+empty_usr_xml <- function() {
+  out <- xml2::xml_new_root(
+    "osm",
+    version = "0.6", generator = "OpenStreetMap server", copyright = "OpenStreetMap and contributors",
+    attribution = "http://www.openstreetmap.org/copyright", license = "http://opendatacommons.org/licenses/odbl/1-0/"
+  )
+
+  return(out)
+}
+
+
+empty_usr_json <- function() {
+  out <- list(
+    version = "0.6", generator = "OpenStreetMap server", copyright = "OpenStreetMap and contributors",
+    attribution = "http://www.openstreetmap.org/copyright", license = "http://opendatacommons.org/licenses/odbl/1-0/",
+    users = list()
+  )
+
+  return(out)
+}

R/osmapi_elements.R

@@ -138,9 +138,6 @@ osm_create_object <- function(x, changeset_id) {
   }
   osm_type <- xml2::xml_name(xml2::xml_child(xml))
 
-  if (length(osm_type) > 1) {
-    warning("More than one OSM object found. Only the first is created.")
-  }
   if (!osm_type[1] %in% c("node", "way", "relation")) {
     warning("Malformed xml. Node name is ", osm_type[1], ", and should be one of `node`, `way` or `relation`.")
   }

R/osmapi_gps_traces.R

@@ -509,6 +509,8 @@ osm_list_gpxs <- function(format = c("R", "xml")) {
 
   if (format == "R") {
     out <- gpx_meta_xml2DF(obj_xml)
+  } else {
+    out <- obj_xml
   }
 
   return(out)

tests/testthat/_snaps/map_notes.md

@@ -133,7 +133,7 @@
 ---
 
     Code
-      print(empty_search_notes)
+      print(empty_search_notes$df)
     Output
       [1] lon          lat          id           url          comment_url 
       [6] close_url    date_created status       comments