clean verbosity options code for update fns #92

ropensci-review-tools · Jan 17, 2025 · 9c53c93 · 9c53c93
1 parent ec5ae97
commit 9c53c93
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 13 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: pkgmatch
 Title:  Find R Packages Matching Either Descriptions or Other R Packages
-Version: 0.4.3.006
+Version: 0.4.3.007
 Authors@R: c(
     person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265")),

diff --git a/R/data-update-cran.R b/R/data-update-cran.R
@@ -30,11 +30,8 @@ pkgmatch_update_cran <- function () {
     cli::cli_inform ("Downloading and analysing {npkgs} packages.")
 
     pt0 <- proc.time ()
-    op <- getOption ("rlib_message_verbosity", "notset")
-    op_is_quiet <- op == "quiet"
-    if (op == "notset") {
-        op <- NULL
-    }
+    op_is_quiet <- opt_is_quiet ()
+    op <- getOption ("rlib_message_verbosity")
     options ("rlib_message_verbosity" = "quiet")
 
     res <- lapply (seq_along (new_cran_pkgs), function (p) {

diff --git a/R/data-update-ropensci.R b/R/data-update-ropensci.R
@@ -30,11 +30,8 @@ pkgmatch_update_ropensci <- function () {
     }
 
     pt0 <- proc.time ()
-    op <- getOption ("rlib_message_verbosity", "notset")
-    op_is_quiet <- op == "quiet"
-    if (op == "notset") {
-        op <- NULL
-    }
+    op_is_quiet <- opt_is_quiet ()
+    op <- getOption ("rlib_message_verbosity")
     options ("rlib_message_verbosity" = "quiet")
 
     res <- lapply (seq_len (nrow (reg_updated)), function (i) {

diff --git a/R/utils.R b/R/utils.R
@@ -1,5 +1,5 @@
 opt_is_quiet <- function () {
-    options ("rlib_message_verbosity") == "quiet"
+    options ("rlib_message_verbosity", "notset") == "quiet"
 }
 
 #' Estimate whether input text string is code or English prose text.

diff --git a/codemeta.json b/codemeta.json
@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/pkgmatch",
   "issueTracker": "https://github.com/ropensci-review-tools/pkgmatch/issues",
   "license": "https://spdx.org/licenses/MIT",
-  "version": "0.4.3.006",
+  "version": "0.4.3.007",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",