-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cross platform terminal settings #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a good & much needed PR. I have added some suggestions for improvement.
thanks, that makes sense. i’m already working on the changes and will push the adjustments soon (probably by tomorrow) |
Hey @ropali, I made some changes based on the review comments. Can you check them? I think the code is now better, more flexible, and simpler. linux: macos: |
I took a quick look and changes look good so far. please allow me some time to review it thoroughly. |
updated how app handle terminal settings for docker exec. now user can choose from more terminal apps like gnome-terminal, konsole, alacritty, xterm, terminator, xfce4-terminal, cmd.exe, powershell.exe, terminal, iterm, and wezterm.
added a dropdown menu in the settings screen where user can pick preferred terminal app. it saves automatically, so when app run a docker exec command, it'll use the terminal selected.
relates: #12
macos:
Area.mp4
linux (fedora):
linux.mp4