Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webmock and shoulda #34

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Add webmock and shoulda #34

merged 1 commit into from
Feb 24, 2017

Conversation

MaicolBen
Copy link
Contributor

@MaicolBen MaicolBen commented Feb 22, 2017

This PR includes:

  • Added webmock to avoid call external APIs by default, an alternative could be mock lib/services mocking but it is easy to forget. Another alternative is vcr but it is more complex, webmock let you know the code to put in case you call the external API. If you want vcr, please make a comment here and we can discuss.
  • Added shoulda as suggest in Add shoulda  #26. devise token auth seems to have an issue with shoulda where it doesn't recognize the uniqueness that devise add by default in the email, if you remove include DeviseTokenAuth::Concerns::User in user, the email validator isn't need to add.

Closes #26

@MaicolBen MaicolBen force-pushed the feature/webmock branch 7 times, most recently from 7d89244 to f5363cf Compare February 23, 2017 13:54
@GAKINDUSTRIES GAKINDUSTRIES merged commit 3f363e2 into master Feb 24, 2017
@MaicolBen MaicolBen deleted the feature/webmock branch March 17, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants