Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add script translations to bundle #274

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Feat: Add script translations to bundle #274

merged 6 commits into from
Jan 25, 2024

Conversation

Dathix
Copy link
Contributor

@Dathix Dathix commented Feb 14, 2023

Proposal for #273

@Dathix Dathix mentioned this pull request Feb 14, 2023
Closed
3 tasks
@Dathix Dathix changed the title Add script translations to bundle Feat: Add script translations to bundle Feb 21, 2023
QWp6t
QWp6t reviewed Feb 26, 2023
View reviewed changes
Copy link
Member

@QWp6t QWp6t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience with i18n. I see room for a minor improvement in the code unless you disagree. I'll wait for someone else on the team more familiar with WordPress i18n to actually test this.

src/Roots/Acorn/Assets/Concerns/Enqueuable.php Outdated Show resolved Hide resolved
@QWp6t
Copy link
Member

QWp6t commented Feb 26, 2023

Should $path default to lang_path()?
Should $domain default to wp_get_theme()->get('TextDomain')?

This is outside my wheelhouse so I'll let others determine whether defaults are a good idea. Just throwing that out there as an idea.

@Dathix
Copy link
Contributor Author

Dathix commented Feb 27, 2023

I like the idea of having these defaults.

@Dathix Dathix force-pushed the script-translations branch from 20ff9ef to 3cd771f Compare February 27, 2023 10:20
@Dathix
Copy link
Contributor Author

Dathix commented Jul 19, 2023

@QWp6t I have added the defaults. Would love to get this feature merged as soon as possible.

@Dathix Dathix requested a review from QWp6t July 20, 2023 06:00
@Dathix
Copy link
Contributor Author

Dathix commented Jul 24, 2023

@QWp6t Thanks!

@Dathix Dathix closed this Jul 24, 2023
@Dathix Dathix reopened this Jul 24, 2023
@QWp6t QWp6t merged commit 4d264ae into roots:main Jan 25, 2024
QWp6t pushed a commit that referenced this pull request Jan 25, 2024
@Dathix @QWp6t
🌐 add Bundle::translate() (#274)
86cb1cc
@Dathix Dathix deleted the script-translations branch February 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QWp6t QWp6t QWp6t left review comments

@retlehs retlehs retlehs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dathix @QWp6t @retlehs