[HS3] Fixes for stability & RooRealIntegral #14733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgard
requested review from
lmoneta,
guitargeek and
dpiparo
as code owners
|
Can one of the admins verify this patch? |
|
@phsft-bot build |
|
Starting build on |
Test Results 13 files 13 suites 3d 1h 39m 39s ⏱️ Results for commit 4960381. ♻️ This comment has been updated with latest results. |
cburgard
changed the title
|
@guitargeek this MR seems to fix all open issues, please review and merge at your convenience! |
Also recognize HistFactory models when the RooRealSumPdf is not the last one in the chain, more rebust processing, added debug printout
Also implement unit tests in `testRooFitHS3.cxx`.
guitargeek
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Thanks a lot for all the effort and sorry for the late review!
I have:
- cleaned up the commit history
- added some fixes for the existing unit tests to pass
- implemented a new unit test for RooRealIntegral
- validated the code with two existing open likelihoods in the JSON format:
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Checklist:
This PR fixes #