Skip to content

Commit

Permalink
[TMVA] Enable again all tests on alma9 and fedora39
Browse files Browse the repository at this point in the history
Now that we're using a system-compatible version of NumPy on the CI
images for these platforms, the TMVA tests should all pass again.
  • Loading branch information
guitargeek committed May 8, 2024
1 parent 5f02783 commit 837e07d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/buildconfig/alma9.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
builtin_nlohmannjson=ON
builtin_vdt=On
tmva-sofie=On
tmva-cpu=OFF
BLA_VENDOR=OpenBLAS
1 change: 0 additions & 1 deletion .github/workflows/root-ci-config/buildconfig/fedora39.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
builtin_nlohmannjson=On
builtin_vdt=On
pythia8=Off
tmva-pymva=Off
5 changes: 0 additions & 5 deletions tutorials/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,6 @@ else()
list(APPEND tmva_veto tmva/TMVA_SOFIE_RSofieReader.C)
list(APPEND tmva_veto tmva/RBatchGenerator_TensorFlow.py)
endif()
# The TMVA_SOFIE_RSofieReader test is disabled because it uses two differnt
# openblas versions via SOFIE and NumPy (indirectly from Keras) at the same
# time. This can cause crashes, for example on alma9.
# TODO: remove the next line once this problem is fixed.
list(APPEND tmva_veto tmva/TMVA_SOFIE_RSofieReader.C)
if (NOT PY_SKLEARN_FOUND)
list(APPEND tmva_veto tmva/TMVA_SOFIE_Models.py)
endif()
Expand Down

0 comments on commit 837e07d

Please sign in to comment.