Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the scorecard github action and its badge #14418

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

harshitasao
Copy link
Contributor

Resolves #14404

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshitasao please fix the commitlint CI.

.github/workflows/scorecards.yml Show resolved Hide resolved
.github/workflows/scorecards.yml Show resolved Hide resolved
@subhamkrai subhamkrai requested a review from travisn July 15, 2024 02:39
@travisn
Copy link
Member

travisn commented Jul 15, 2024

Before we merge this, let's take a quick look at the report to see what low hanging fruit there is to improve the score. Thanks @obnoxxx for taking a look!

@harshitasao
Copy link
Contributor Author

@travisn As my next step, I will be creating a separate scorecard score improvement issue something like this and fix each check where the score is dropping, thus improving the project's security posture.

@BlaineEXE
Copy link
Member

Hi @harshitasao, we have addressed one of the high priority items. Could you re-run the workflow so we can see what the latest score looks like? Alternatively, it would be nice to know what steps you used to run the workflow and get a result published.

@harshitasao
Copy link
Contributor Author

Hi @harshitasao, we have addressed one of the high priority items. Could you re-run the workflow so we can see what the latest score looks like? Alternatively, it would be nice to know what steps you used to run the workflow and get a result published.

We cannot run the action manually; it will run only after getting merged into the project. If the action is not added to the project, the Scorecard team runs a weekly scan of public GitHub repositories in order to track the overall security health of the open source ecosystem.

@obnoxxx
Copy link
Contributor

obnoxxx commented Aug 14, 2024

@subhamkrai wrote:

@harshitasao please fix the commitlint CI.

This has been fixed meanwhile 👍🏼

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @harshitasao !
I think requests have been addressed and explained.
LGTM now.

@travisn travisn dismissed subhamkrai’s stale review August 14, 2024 17:09

question answered

@travisn travisn merged commit 9546b71 into rook:master Aug 14, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable OpenSSF Scorecard to enhance security practices across the project
5 participants