Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert .romm-version file #337

Merged
merged 2 commits into from
Aug 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Set version
run: VERSION=$(cat .romm-version); sed -i "s/<romm_version>/$VERSION/" pyproject.toml
- name: Install mariadb connectors
run: |
sudo apt-get update
Expand Down
1 change: 0 additions & 1 deletion .romm-version

This file was deleted.

3 changes: 0 additions & 3 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ FROM node:lts-alpine as front-build-stage
COPY ./.romm-version /
WORKDIR /front
COPY ./frontend ./
RUN sed -i -r "s/<romm_version>/$(cat /.romm-version)/g" ./package.json
RUN sed -i -r "s/<romm_version>/$(cat /.romm-version)/g" ./package-lock.json
RUN npm install
RUN npm run build

Expand Down Expand Up @@ -33,7 +31,6 @@ RUN apt update && \
COPY ./.romm-version /
WORKDIR /back
COPY ./pyproject.toml ./poetry.lock ./
RUN sed -i -r "s/<romm_version>/$(cat /.romm-version)/g" ./pyproject.toml
RUN pip install --no-cache --upgrade pip && \
pip install --no-cache poetry && \
poetry config virtualenvs.create false && \
Expand Down
4 changes: 2 additions & 2 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "romm",
"version": "<romm_version>",
"version": "1.9.2",
"private": true,
"scripts": {
"dev": "vite --host",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "RomM"
version = "<romm_version>"
version = "1.9.2"
description = "RomM (Rom Manager) is a web based retro roms manager integrated with IGDB."
authors = ["zurdi <[email protected]>"]
readme = "README.md"
Expand Down