[ROMM-1505] Skip CSRF checks when request has Authorization header #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results93 tests 93 ✅ 26s ⏱️ Results for commit 6927a97. ♻️ This comment has been updated with latest results. |
adamantike
reviewed
Jan 22, 2025
backend/handler/auth/middleware.py
Outdated
| request = Request(scope, receive) | ||
|
|
||
| # Skip CSRF check if Authorization header is present | ||
| if "Authorization" in request.headers: |
There was a problem hiding this comment.
To avoid false positives and requests that skip CSRF without sending a valid header, I would change this to:
auth_scheme = request.headers.get("Authorization", "").split(" ", 1)[0].lower()
if auth_scheme == "bearer" or auth_scheme == "basic":
adamantike
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes igdb_id and moby_id getting unset when not provided to
updateendpoint.Fixes #1505