Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-1452] Mark naive datetimes as UTC #1456

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[ROMM-1452] Mark naive datetimes as UTC #1456

merged 2 commits into from
Jan 10, 2025

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jan 10, 2025

The new BaseModel assumes all naive datetimes are in UTC, which should usually be the case since we use datetime.now(timezone.utc) when updating fields.

Fixes #1452

@gantoine gantoine requested a review from adamantike January 10, 2025 01:52
Copy link

github-actions bot commented Jan 10, 2025

Test Results

93 tests  ±0   93 ✅ ±0   26s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ebc91b0. ± Comparison against base commit de74688.

♻️ This comment has been updated with latest results.

@gantoine gantoine merged commit 3cf7b33 into master Jan 10, 2025
8 checks passed
@gantoine gantoine deleted the romm-1452 branch January 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants