fix: Improve OIDC email verified check #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OIDC email verified check now fails if the email is explicitly unverified, or if the `email_verified` claim is supported and the email is not explicitly verified. Previously, the OIDC implementation failed for any OIDC provider that did not include the `email_verified` claim in the userinfo response. Providers like Synology do not include this claim, so the check always failed with error "Email is not verified." I haven't found a formal specification for the `email_verified` claim, and how it should be handled, but this implementation should be more robust and work with more OIDC providers. Fixes #1446.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OIDC email verified check now fails if the email is explicitly unverified, or if the
email_verifiedclaim is supported and the email is not explicitly verified.Previously, the OIDC implementation failed for any OIDC provider that did not include the
email_verifiedclaim in the userinfo response. Providers like Synology do not include this claim, so the check always failed with error "Email is not verified."I haven't found a formal specification for the
email_verifiedclaim, and how it should be handled, but this implementation should be more robust and work with more OIDC providers.Fixes #1446.