Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROMM-1414] Env var to disable user/pass login button #1429

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[ROMM-1414] Env var to disable user/pass login button #1429

merged 5 commits into from
Jan 7, 2025

Conversation

gantoine
Copy link
Member

@gantoine gantoine commented Jan 7, 2025 •
edited
Loading

Screenshot 2025-01-07 at 5 29 30 PM

@gantoine gantoine requested review from adamantike and zurdi15 January 7, 2025 21:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Test Results

91 tests  ±0   91 ✅ ±0   26s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 04c3137. ± Comparison against base commit 390156b.

♻️ This comment has been updated with latest results.

zurdi15
zurdi15 requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@zurdi15 zurdi15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would conditional render the v-form instead of the v-btn since the form is unused when standard login is disabled

@zurdi15 zurdi15 changed the base branch from release to master January 7, 2025 22:09
@gantoine gantoine requested a review from zurdi15 January 7, 2025 22:29
@gantoine gantoine merged commit c8275a0 into master Jan 7, 2025
9 checks passed
@gantoine gantoine deleted the romm-1414 branch January 7, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurdi15 zurdi15 zurdi15 approved these changes

@adamantike adamantike Awaiting requested review from adamantike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gantoine @zurdi15